Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix nightly scala pipeline #16362

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix nightly scala pipeline #16362

merged 1 commit into from
Oct 3, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Oct 3, 2019 •
edited
Loading

Description

Fix the Dockerfiles used for the Scala nightly publishing job.

I successfully ran this on the dev Jenkins at http://jenkins.mxnet-ci-dev.amazon-ml.com/job/restricted-publish-artifacts/job/automate-maven/196/.

@samskalicky @aaronmarkham

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk requested a review from lanking520 October 3, 2019 00:27
samskalicky
samskalicky approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@aaronmarkham aaronmarkham merged commit b6f3235 into apache:master Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

@lanking520 lanking520 lanking520 approved these changes

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@samskalicky samskalicky samskalicky approved these changes

Assignees
No one assigned
Labels
CI Scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zachgk @samskalicky @aaronmarkham @lanking520 @marcoabreu